Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/21825 )
Change subject: IMPALA-889: Add trim() function matching ANSI SQL definition ...................................................................... Patch Set 2: (9 comments) Thanks Mihaly! http://gerrit.cloudera.org:8080/#/c/21825/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21825/2//COMMIT_MSG@16 PS2, Line 16: https://gerrit.sjc.cloudera.com/c/Impala/+/4579 Please do not refer to downstream resources. http://gerrit.cloudera.org:8080/#/c/21825/2//COMMIT_MSG@51 PS2, Line 51: Alghough typo: Although http://gerrit.cloudera.org:8080/#/c/21825/2//COMMIT_MSG@52 PS2, Line 52: negativa typo: negative http://gerrit.cloudera.org:8080/#/c/21825/2/fe/src/main/cup/sql-parser.cup File fe/src/main/cup/sql-parser.cup: http://gerrit.cloudera.org:8080/#/c/21825/2/fe/src/main/cup/sql-parser.cup@3861 PS2, Line 3861: | function_name:fn_name LPAREN ident_or_default:i KW_FROM expr:e RPAREN This syntax rule will also match date_part(year from now()) and create a TrimFromExpr which creates an unnecessary wrapping for the date_part function call. http://gerrit.cloudera.org:8080/#/c/21825/2/fe/src/main/cup/sql-parser.cup@3873 PS2, Line 3873: compromizing typo:compromising http://gerrit.cloudera.org:8080/#/c/21825/2/fe/src/main/java/org/apache/impala/analysis/TrimFromExpr.java File fe/src/main/java/org/apache/impala/analysis/TrimFromExpr.java: http://gerrit.cloudera.org:8080/#/c/21825/2/fe/src/main/java/org/apache/impala/analysis/TrimFromExpr.java@19 PS2, Line 19: : import com.google.common.base.Joiner; : import com.google.common.base.Preconditions; : import com.google.common.collect.ImmutableSet; unused imports http://gerrit.cloudera.org:8080/#/c/21825/2/fe/src/main/java/org/apache/impala/analysis/TrimFromExpr.java@45 PS2, Line 45: private final FunctionName fnName_; We can reuse the fnName_ from FunctionCallExpr http://gerrit.cloudera.org:8080/#/c/21825/2/fe/src/main/java/org/apache/impala/analysis/TrimFromExpr.java@48 PS2, Line 48: private final Expr srcexpr_; could be srcExpr_ http://gerrit.cloudera.org:8080/#/c/21825/2/fe/src/main/java/org/apache/impala/analysis/TrimFromExpr.java@139 PS2, Line 139: "Expression '" + charset_.toSql() + "' has a return type of "); : errMsg.append(charset_.getType().toSql() + " but a STRING is required." This error message template could be extracted as a format string and reused in L144. -- To view, visit http://gerrit.cloudera.org:8080/21825 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3c4fa6d0d8d0684c4b6d8dac8fd531d205e4f7b4 Gerrit-Change-Number: 21825 Gerrit-PatchSet: 2 Gerrit-Owner: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Fri, 20 Sep 2024 14:20:52 +0000 Gerrit-HasComments: Yes
