Hello [email protected], Zoltan Borok-Nagy, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/21730

to look at the new patch set (#2).

Change subject: IMPALA-13336: Fix syntax error in creating Iceberg test table 
on Apache Hive 3
......................................................................

IMPALA-13336: Fix syntax error in creating Iceberg test table on Apache Hive 3

Apache Hive 3 doesn't support the syntax of STORED BY ICEBERG STORED AS
AVRO. When loading test data on Apache Hive 3, we convert this clause to
  STORED BY 'org.apache.iceberg.mr.hive.HiveIcebergStorageHandler'
  TBLPROPERTIES('write.format.default'='AVRO')
However, when there is a LOCATION clause in the statement, the
TBLPROPERTIES clause will be put before the LOCATION clause, which
causes the syntax error.

In the CreateTable statement, TBLPROPERTIES clause should be put after
the LOCATION clause. This patch fixes generate-schema-statements.py to
take care of this case.

Tests:
 - Verified the SQL files generated by generate-schema-statements.py

Change-Id: I5b47d6dc1a2ab63d4ecea476dbab67c1ae8ca490
---
M testdata/bin/generate-schema-statements.py
1 file changed, 16 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/30/21730/2
--
To view, visit http://gerrit.cloudera.org:8080/21730
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5b47d6dc1a2ab63d4ecea476dbab67c1ae8ca490
Gerrit-Change-Number: 21730
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>

Reply via email to