Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21796 )
Change subject: IMPALA-13377: Excercise exec_option in test_recover_partitions.py ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/21796/3/tests/metadata/test_recover_partitions.py File tests/metadata/test_recover_partitions.py: http://gerrit.cloudera.org:8080/#/c/21796/3/tests/metadata/test_recover_partitions.py@69 PS3, Line 69: my_client = self.create_impala_client(protocol=vector.get_value('protocol')) > I like that method! Oh, I thought we use subprocess so it's safe. When running the parallel e2e tests, we use the "-n numprocesses" parameter of pytest: https://github.com/apache/impala/blob/58fd45f20c22f8a062f603d6b96f62ee57d85ca9/tests/run-tests.py#L322 If it's using threads, lots of codes should change as well since 'self.client' is used, e.g. https://github.com/apache/impala/blob/58fd45f20c22f8a062f603d6b96f62ee57d85ca9/tests/common/impala_test_suite.py#L923 https://github.com/apache/impala/blob/58fd45f20c22f8a062f603d6b96f62ee57d85ca9/tests/common/impala_test_suite.py#L1027-L1028 Do you see the query options are set incorrectly when not creating a new client? -- To view, visit http://gerrit.cloudera.org:8080/21796 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4e938dd8667937c996854032a1e13184c62d7b48 Gerrit-Change-Number: 21796 Gerrit-PatchSet: 4 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Thu, 19 Sep 2024 08:56:26 +0000 Gerrit-HasComments: Yes
