Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21797 )
Change subject: IMPALA-12594: Add flag to tune KrpcDataStreamSender mem estimate ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/21797/1/fe/src/main/java/org/apache/impala/planner/DataStreamSink.java File fe/src/main/java/org/apache/impala/planner/DataStreamSink.java: http://gerrit.cloudera.org:8080/#/c/21797/1/fe/src/main/java/org/apache/impala/planner/DataStreamSink.java@100 PS1, Line 100: boolean use_be_logic = be_buffer_bytes > 0 && outputPartition_.isPartitioned(); If getAvgSerializedRowSize() is significantly larger than getFixedLenRowSize(), should we favor prior carculation instead? I'm thinking a flag, say, data_stream_sender_large_row_threshold, and then: boolean use_be_logic = be_buffer_bytes > 0 && outputPartition_.isPartitioned() && (ExchangeNode.getAvgSerializedRowSize(exchNode_) < data_stream_sender_large_row_threshold * exchNode_.getFixedLenRowSize()); -- To view, visit http://gerrit.cloudera.org:8080/21797 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1e4b1db030be934cece565e3f2634ee7cbdb7c4f Gerrit-Change-Number: 21797 Gerrit-PatchSet: 1 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Fri, 13 Sep 2024 16:12:39 +0000 Gerrit-HasComments: Yes
