Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21337 )
Change subject: IMPALA-12922: Make batch_sizes an optional test dimension ...................................................................... Patch Set 3: (4 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python2 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with virtualenv installed. http://gerrit.cloudera.org:8080/#/c/21337/3/tests/common/custom_cluster_test_suite.py File tests/common/custom_cluster_test_suite.py: http://gerrit.cloudera.org:8080/#/c/21337/3/tests/common/custom_cluster_test_suite.py@96 PS3, Line 96: = flake8: E712 comparison to False should be 'if cond is False:' or 'if not cond:' http://gerrit.cloudera.org:8080/#/c/21337/3/tests/metadata/test_explain.py File tests/metadata/test_explain.py: http://gerrit.cloudera.org:8080/#/c/21337/3/tests/metadata/test_explain.py@47 PS3, Line 47: = flake8: E712 comparison to False should be 'if cond is False:' or 'if not cond:' http://gerrit.cloudera.org:8080/#/c/21337/3/tests/query_test/test_hash_join_timer.py File tests/query_test/test_hash_join_timer.py: http://gerrit.cloudera.org:8080/#/c/21337/3/tests/query_test/test_hash_join_timer.py@93 PS3, Line 93: = flake8: E712 comparison to False should be 'if cond is False:' or 'if not cond:' http://gerrit.cloudera.org:8080/#/c/21337/3/tests/query_test/test_rows_availability.py File tests/query_test/test_rows_availability.py: http://gerrit.cloudera.org:8080/#/c/21337/3/tests/query_test/test_rows_availability.py@62 PS3, Line 62: = flake8: E712 comparison to False should be 'if cond is False:' or 'if not cond:' -- To view, visit http://gerrit.cloudera.org:8080/21337 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I39afa892ecf78b717686d59d7fdd1877a64d609f Gerrit-Change-Number: 21337 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Thu, 12 Sep 2024 02:23:59 +0000 Gerrit-HasComments: Yes
