Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21684 )
Change subject: IMPALA-13302: Restore registering all conjuncts ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/21684/6/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: http://gerrit.cloudera.org:8080/#/c/21684/6/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@3356 PS6, Line 3356: conjunct.getId() == null || globalState_.conjuncts.containsKey(conjunct.getId()), > Removing the check "conjunct.getId() == null" is better, but flags a bunch I think I see two issues: - Calling assign on conjuncts that are never registered; this seems to be somewhat endemic, I'd like to cover that with another ticket. - Creating new SelectStmt in createSingleNodePlan as part of an inline view, where we translate conjuncts through an outputSmap. ExprSubstitutionMap generally clones its RHS, so '==' won't work there. In some cases 'equals' doesn't seem to work either even though visually it looks like they should be equal; somehow 'row_number()' gets two different SlotRefs with different IDs, so they're not equal. -- To view, visit http://gerrit.cloudera.org:8080/21684 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5959a3b3e18302e00b1d37e5f50410ebdb224cb0 Gerrit-Change-Number: 21684 Gerrit-PatchSet: 6 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 04 Sep 2024 23:41:30 +0000 Gerrit-HasComments: Yes
