Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/21629 )
Change subject: IMPALA-13030: [DOCS] Documentation of AI built-in function (ai_generate_text) ...................................................................... Patch Set 2: (7 comments) http://gerrit.cloudera.org:8080/#/c/21629/2/docs/topics/impala_ai_functions.xml File docs/topics/impala_ai_functions.xml: http://gerrit.cloudera.org:8080/#/c/21629/2/docs/topics/impala_ai_functions.xml@99 PS2, Line 99: nit. one space is better http://gerrit.cloudera.org:8080/#/c/21629/2/docs/topics/impala_ai_functions.xml@100 PS2, Line 100: should be no space here http://gerrit.cloudera.org:8080/#/c/21629/2/docs/topics/impala_ai_functions.xml@101 PS2, Line 101: the : function uses the default values set at the instance level instead Maybe expand the sentence to clarify that the default values are from the flag values, "The function uses the default values set at the instance level, which correspond to the flag values configured in the Impala instance. For example, the flag value of ai_endpoint will be used as the default ai_endpoint value when the argument is NULL or empty" http://gerrit.cloudera.org:8080/#/c/21629/2/docs/topics/impala_ai_functions.xml@130 PS2, Line 130: nit. unnecessary spaces http://gerrit.cloudera.org:8080/#/c/21629/2/docs/topics/impala_ai_functions.xml@138 PS2, Line 138: nit. unnecessary spaces http://gerrit.cloudera.org:8080/#/c/21629/2/docs/topics/impala_ai_functions.xml@174 PS2, Line 174: data sets Seems "datasets" is more commonly used in this context http://gerrit.cloudera.org:8080/#/c/21629/2/docs/topics/impala_ai_functions.xml@183 PS2, Line 183: nit. unnecessary spaces -- To view, visit http://gerrit.cloudera.org:8080/21629 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iae921f6554c7010f9568ee4a42b4abcb3534d4a6 Gerrit-Change-Number: 21629 Gerrit-PatchSet: 2 Gerrit-Owner: Sanjana Malhotra <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Anonymous Coward (801) Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 04 Sep 2024 17:51:56 +0000 Gerrit-HasComments: Yes
