Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21653 )
Change subject: IMPALA-12737: Refactor the Workload Management Initialization Process. ...................................................................... Patch Set 34: Code-Review-1 (1 comment) http://gerrit.cloudera.org:8080/#/c/21653/34/be/src/service/workload-management.h File be/src/service/workload-management.h: http://gerrit.cloudera.org:8080/#/c/21653/34/be/src/service/workload-management.h@81 PS34, Line 81: const std::string& FieldName() const { The result of this function is always copied to a stringstream. If we're going to optimize this, I'd rather do it without maintaining yet another copy. Thrift already defines an operator<< for TQueryTableColumn::type. I only used to_string to be able to change the case. So let's drop FieldName() altogether and just directly use db_column in its place. -- To view, visit http://gerrit.cloudera.org:8080/21653 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id645f94c8da73b91c13a23d7ac0ea026425f0f96 Gerrit-Change-Number: 21653 Gerrit-PatchSet: 34 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 27 Aug 2024 23:33:53 +0000 Gerrit-HasComments: Yes
