Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21653 )
Change subject: IMPALA-12737: Refactor the Workload Management Initialization Process. ...................................................................... Patch Set 30: (2 comments) http://gerrit.cloudera.org:8080/#/c/21653/30/be/src/service/workload-management.h File be/src/service/workload-management.h: http://gerrit.cloudera.org:8080/#/c/21653/30/be/src/service/workload-management.h@80 PS30, Line 80: SetFormattedColName(); The field definitions table that creates this is statically constructed, as is _TQueryTableColumn_VALUES_TO_NAMES which is used to convert to string names. So there's no guarantee which will be initialized first. I wouldn't worry about the conversion cost (to_string is a constant table lookup by index) and just do to_string in FormattedColName. http://gerrit.cloudera.org:8080/#/c/21653/30/be/src/service/workload-management.h@90 PS30, Line 90: void SetFormattedColName(); > Where did you move the definition? workload-management.cc. -- To view, visit http://gerrit.cloudera.org:8080/21653 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id645f94c8da73b91c13a23d7ac0ea026425f0f96 Gerrit-Change-Number: 21653 Gerrit-PatchSet: 30 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 27 Aug 2024 18:53:40 +0000 Gerrit-HasComments: Yes
