Zihao Ye has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/21701


Change subject: IMPALA-12957: Support reading Inf and NaN from JSON
......................................................................

IMPALA-12957: Support reading Inf and NaN from JSON

Despite the fact that special values such as Inf and NaN are not
supported in standard JSON (they are considered invalid values),
rapidjson does support them. However, it requires the parsing flag
'kParseNanAndInfFlag' to be enabled.
This patch enables the flag to allows JsonParser to parse special
numbers like Inf and NaN. Corresponding modifications have also been
made to JsonSkipper to maintain consistent behavior when zero slots
scans.

TODO: Due to a bug in rapidjson when parsing NaN and Inf with fractional
or exponent parts (https://github.com/Tencent/rapidjson/issues/2299),
JsonSkipper has "inherited" this bug to maintain consistent behavior.
After upgrading rapidjson to resolve this issue, JsonSkipper's code
should also be modified accordingly.

Testing:
  - Added and passed relevant test cases (BE, E2E).

Change-Id: I05ee7c7c7fb7e78fff9570f659ce2d13c94a4e10
---
M be/src/exec/json/json-parser-test.cc
M be/src/exec/json/json-parser.cc
M be/src/exec/json/json-parser.h
M testdata/data/json_test/overflow.json
M testdata/workloads/functional-query/queries/QueryTest/overflow_json.test
5 files changed, 43 insertions(+), 18 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/01/21701/1
--
To view, visit http://gerrit.cloudera.org:8080/21701
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I05ee7c7c7fb7e78fff9570f659ce2d13c94a4e10
Gerrit-Change-Number: 21701
Gerrit-PatchSet: 1
Gerrit-Owner: Zihao Ye <[email protected]>

Reply via email to