Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21671 )
Change subject: IMPALA-13274: Filter out illegal output for certain join nodes ...................................................................... Patch Set 8: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/21671/8/fe/src/main/java/org/apache/impala/planner/JoinNode.java File fe/src/main/java/org/apache/impala/planner/JoinNode.java: http://gerrit.cloudera.org:8080/#/c/21671/8/fe/src/main/java/org/apache/impala/planner/JoinNode.java@220 PS8, Line 220: result.put(lhs.get(i).clone(), rhs.get(i).clone()); I think we can skip cloning the LHS. It shouldn't be mutated in ways that would affect it's use as a key. -- To view, visit http://gerrit.cloudera.org:8080/21671 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I50b82d85737025df2fdd9e7ab0fca2385e642415 Gerrit-Change-Number: 21671 Gerrit-PatchSet: 8 Gerrit-Owner: ttttttz <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Zihao Ye <[email protected]> Gerrit-Reviewer: ttttttz <[email protected]> Gerrit-Comment-Date: Mon, 19 Aug 2024 17:08:03 +0000 Gerrit-HasComments: Yes
