Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21597 )
Change subject: IMPALA-13246: Smallify strings during broadcast exchange ...................................................................... IMPALA-13246: Smallify strings during broadcast exchange Other changes: - adds smallifying of strings in collections - removes Tuple::SmallifyStrings() and smallifies during deep copy instead - this seems somewhat slower in TPC-H, but is safer as it doesn't rely on the assumption that smallify is always done for the whole tuple (it turned out that this is not true in some cases) Measured 0.5-1% improvement in TPCH(42). note that there is a very similar WIP change: https://gerrit.cloudera.org/#/c/21508/ Change-Id: I281d77c7a241ebfe8716eb5c975f0660601aec1b Reviewed-on: http://gerrit.cloudera.org:8080/21597 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/benchmarks/row-batch-serialize-benchmark.cc M be/src/runtime/buffered-tuple-stream-test.cc M be/src/runtime/buffered-tuple-stream.cc M be/src/runtime/row-batch-serialize-test.cc M be/src/runtime/row-batch.cc M be/src/runtime/smallable-string.h M be/src/runtime/string-value.h M be/src/runtime/tuple.cc M be/src/runtime/tuple.h 9 files changed, 67 insertions(+), 47 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/21597 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I281d77c7a241ebfe8716eb5c975f0660601aec1b Gerrit-Change-Number: 21597 Gerrit-PatchSet: 11 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
