Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21662 )
Change subject: IMPALA-12758: Event processor is ignoring the prev_id while reloading existing partitions ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/21662/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/21662/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@3019 PS1, Line 3019: oldPartition Based on L3020 and L3023, 'oldPartition' could be null. http://gerrit.cloudera.org:8080/#/c/21662/1/tests/custom_cluster/test_events_custom_configs.py File tests/custom_cluster/test_events_custom_configs.py: http://gerrit.cloudera.org:8080/#/c/21662/1/tests/custom_cluster/test_events_custom_configs.py@1310 PS1, Line 1310: @CustomClusterTestSuite.with_args(catalogd_args="--hms_event_polling_interval_s=5") Should we test on local-catalog mode? 'prev_id' of HdfsPartition is not used in ImpaladCatalog (i.e. legacy catalog mode). http://gerrit.cloudera.org:8080/#/c/21662/1/tests/custom_cluster/test_events_custom_configs.py@1324 PS1, Line 1324: self.assert_impalad_log_contains('INFO', log_regex.format(3, 3, 3)) This test passes without the fix. Can we add one that will fail without the fix? -- To view, visit http://gerrit.cloudera.org:8080/21662 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia7d53f601b63d83e99cbd2d1f58076a0dc78c610 Gerrit-Change-Number: 21662 Gerrit-PatchSet: 1 Gerrit-Owner: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Thu, 15 Aug 2024 11:51:01 +0000 Gerrit-HasComments: Yes
