Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21655 )
Change subject: IMPALA-13293: Fix too long wait for initial catalog update ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Thanks for working on this! The change looks good to me, but I have some confusion at one part. http://gerrit.cloudera.org:8080/#/c/21655/3/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/21655/3/fe/src/main/java/org/apache/impala/service/Frontend.java@1889 PS3, Line 1889: // Avoid calling getCatalog again in this attempt as it may return a different : // ImpaladCatalog if a full topic update has arrived. Wouldn't it be better to wait on the new catalog then? -- To view, visit http://gerrit.cloudera.org:8080/21655 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4da1d0c0d25f80b02c39be863431201d1b913c5d Gerrit-Change-Number: 21655 Gerrit-PatchSet: 3 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 13 Aug 2024 16:54:22 +0000 Gerrit-HasComments: Yes
