Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21643 )
Change subject: IMPALA-13272: Analyitic function of collections can lead to crash ...................................................................... Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/21643/2/fe/src/main/java/org/apache/impala/analysis/SlotDescriptor.java File fe/src/main/java/org/apache/impala/analysis/SlotDescriptor.java: http://gerrit.cloudera.org:8080/#/c/21643/2/fe/src/main/java/org/apache/impala/analysis/SlotDescriptor.java@154 PS2, Line 154: > nit: we usually write it with a 'z'. Even if both forms are correct, it mak We've used both the US and UK/Australian forms in Impala for a long time (think of Tim), the code base is already full of both. I've changed it but I'm not sure there's much to be gained. http://gerrit.cloudera.org:8080/#/c/21643/2/fe/src/main/java/org/apache/impala/analysis/SlotDescriptor.java@161 PS2, Line 161: > It's a bit confusing to have isMaterializedRecursively() and isFullyMateria Changed it to 'shouldMaterializeRecursively_', because it is involved with materialisation too, see L144. http://gerrit.cloudera.org:8080/#/c/21643/2/fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java File fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java: http://gerrit.cloudera.org:8080/#/c/21643/2/fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java@332 PS2, Line 332: materialized > nit: as I mentioned, IMO it is not good to mix 'materialised' and 'material Extended the comment. http://gerrit.cloudera.org:8080/#/c/21643/2/testdata/workloads/functional-query/queries/QueryTest/sort-complex.test File testdata/workloads/functional-query/queries/QueryTest/sort-complex.test: http://gerrit.cloudera.org:8080/#/c/21643/2/testdata/workloads/functional-query/queries/QueryTest/sort-complex.test@154 PS2, Line 154: # Regression test for # IMPALA-13272 > Can we also add the following query: Done http://gerrit.cloudera.org:8080/#/c/21643/4/testdata/workloads/functional-query/queries/QueryTest/sort-complex.test File testdata/workloads/functional-query/queries/QueryTest/sort-complex.test: http://gerrit.cloudera.org:8080/#/c/21643/4/testdata/workloads/functional-query/queries/QueryTest/sort-complex.test@196 PS4, Line 196: select Here we may need to limit the result set to 2 because I don't think the ordering of NULLs with respect to each other is guaranteed to be stable, so the order may vary. What do you think? -- To view, visit http://gerrit.cloudera.org:8080/21643 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I71d1fa28ad4ff2e1a8fc5b91d3fc271c33765190 Gerrit-Change-Number: 21643 Gerrit-PatchSet: 4 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 05 Aug 2024 15:17:00 +0000 Gerrit-HasComments: Yes
