Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21045 )
Change subject: IMPALA-12771: Impala catalogd events-skipped may mark the wrong number ...................................................................... IMPALA-12771: Impala catalogd events-skipped may mark the wrong number This patch modified the description of events-skipped metric which missing the description of ATLER event for DB and Table. Besides there are some cases where event-skipped metric is incorrectly marked, most are for transactional table: 1. The metric should increase when processing AddPartitionEvent on the transactional table which is not in loaded state or when db is not found. 2. The metric should increase when processing AlterPartitionEvent on the transactional table which is not in loaded status or when db is not found. 3. The metric should increase when processing AlterPartitionEvent if the event is a trivial event and can be skipped. 4. When processing BatchPartitionEvent, the number of skipped event is not marked before doing any real work. 5. The metric should increase when processing DropPartitionEvent on the transactional table which is not in loaded status or when db is not found. testing: - add test cases for add database, creata table, alter table, add partition , create transactional table,alter partition for transactional and test the skipped metric number. Change-Id: I7aeb04e999b82187eb138c0b643ead259da22f1a Reviewed-on: http://gerrit.cloudera.org:8080/21045 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java M fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java 4 files changed, 181 insertions(+), 46 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/21045 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I7aeb04e999b82187eb138c0b643ead259da22f1a Gerrit-Change-Number: 21045 Gerrit-PatchSet: 21 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]>
