Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/21142 )
Change subject: IMPALA-12737: List columns in profile and query history ...................................................................... Patch Set 26: (4 comments) http://gerrit.cloudera.org:8080/#/c/21142/26//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21142/26//COMMIT_MSG@9 PS26, Line 9: "Select Columns", "Where Columns", "Join Columns", "Aggregate : Columns", and "OrderBy Columns" > I thought it was only used with "GROUP BY", but looks like it can be used s Michael did make the change to include the HAVING columns in the aggregate_columns. http://gerrit.cloudera.org:8080/#/c/21142/26/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java File fe/src/main/java/org/apache/impala/analysis/SelectStmt.java: http://gerrit.cloudera.org:8080/#/c/21142/26/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java@383 PS26, Line 383: Stream<SelectListItem> nonStarItems = : selectList_.getItems().stream().filter(elem -> !elem.isStar()); : nonStarItems.forEach(item -> item.getExpr().collect(SlotRef.class, slotRefs)); > Will do. Done http://gerrit.cloudera.org:8080/#/c/21142/26/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java@387 PS26, Line 387: .filter(path -> path != null) > Probably not needed for concatenated stream, but wouldn't hurt. There are a Done http://gerrit.cloudera.org:8080/#/c/21142/26/tests/util/workload_management.py File tests/util/workload_management.py: http://gerrit.cloudera.org:8080/#/c/21142/26/tests/util/workload_management.py@30 PS26, Line 30: CLUSTER_ID = "CLUSTER_ID" : QUERY_ID = "QUERY_ID" : SESSION_ID = "SESSION_ID" > Maybe, that'd be nice to sync up. Done -- To view, visit http://gerrit.cloudera.org:8080/21142 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I78f3670b067c0c192ee8a212fba95466fbcb51d7 Gerrit-Change-Number: 21142 Gerrit-PatchSet: 26 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Mon, 29 Jul 2024 19:33:38 +0000 Gerrit-HasComments: Yes
