Wenzhe Zhou has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/21617


Change subject: IMPALA-13256: Support more than 2G rows for count star on jdbc 
table
......................................................................

IMPALA-13256: Support more than 2G rows for count star on jdbc table

Function DatabaseAccessor.getTotalNumberOfRecords() is defined with
return data type as int. This causes Impala to thrown exception when
executing count star query for jdbc tables with more than 2G rows.
This patch fixed the issue by changing the function return type as
long. The number of rows in each RowBatch fetched from jdbc data
source cannot exceed 2G.

Testing:
 - Passed core-test.
 - Manually created a jdbc table jdbc_table with more than 2G rows,
   verified that query 'select count(*) from jdbc_table' returned
   correct number of rows.

Change-Id: I47db58300cbe3270bab07da02c3fcde6d7072334
---
M be/src/exec/data-source-scan-node.cc
M fe/src/main/java/org/apache/impala/extdatasource/jdbc/JdbcDataSource.java
M 
fe/src/main/java/org/apache/impala/extdatasource/jdbc/dao/DatabaseAccessor.java
M 
fe/src/main/java/org/apache/impala/extdatasource/jdbc/dao/GenericJdbcDatabaseAccessor.java
4 files changed, 15 insertions(+), 11 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/17/21617/2
--
To view, visit http://gerrit.cloudera.org:8080/21617
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I47db58300cbe3270bab07da02c3fcde6d7072334
Gerrit-Change-Number: 21617
Gerrit-PatchSet: 2
Gerrit-Owner: Wenzhe Zhou <[email protected]>
Gerrit-Reviewer: Abhishek Rawat <[email protected]>
Gerrit-Reviewer: Pranav Lodha <[email protected]>
Gerrit-Reviewer: Yifan Zhang <[email protected]>

Reply via email to