Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20447 )
Change subject: IMPALA-13039: AES Encryption/ Decryption Support in Impala ...................................................................... Patch Set 12: (10 comments) http://gerrit.cloudera.org:8080/#/c/20447/10/be/src/exprs/string-functions-ir.cc File be/src/exprs/string-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/20447/10/be/src/exprs/string-functions-ir.cc@1869 PS10, Line 1869: > I hope its fine now. Done http://gerrit.cloudera.org:8080/#/c/20447/12/be/src/exprs/string-functions-ir.cc File be/src/exprs/string-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/20447/12/be/src/exprs/string-functions-ir.cc@1855 PS12, Line 1855: EncryptionKey t; nit: this variable name could be more descriptive http://gerrit.cloudera.org:8080/#/c/20447/12/be/src/exprs/string-functions-ir.cc@1856 PS12, Line 1856: AES_CIPHER_MODE mode_; nit: I'm not sure why mode_ has an underscore at the end. That's usually reserved for private class instance variables, but this is a local variable. http://gerrit.cloudera.org:8080/#/c/20447/12/be/src/exprs/string-functions-ir.cc@1893 PS12, Line 1893: if (mode_ == AES_CIPHER_MODE::AES_128_GCM use t.IsGcmMode() http://gerrit.cloudera.org:8080/#/c/20447/12/be/src/exprs/string-functions-ir.cc@1910 PS12, Line 1910: if (mode_ == AES_CIPHER_MODE::AES_128_GCM use t.IsGcmMode() http://gerrit.cloudera.org:8080/#/c/20447/12/be/src/exprs/string-functions-ir.cc@1941 PS12, Line 1941: EncryptionKey t; nit: this variable name could be more descriptive http://gerrit.cloudera.org:8080/#/c/20447/12/be/src/exprs/string-functions-ir.cc@1942 PS12, Line 1942: AES_CIPHER_MODE mode_; nit: I'm not sure why mode_ has an underscore at the end. That's usually reserved for private class instance variables, but this is a local variable. http://gerrit.cloudera.org:8080/#/c/20447/12/be/src/exprs/string-functions-ir.cc@1975 PS12, Line 1975: if (mode_ == AES_CIPHER_MODE::AES_128_GCM use t.IsGcmMode() http://gerrit.cloudera.org:8080/#/c/20447/10/be/src/util/openssl-util.cc File be/src/util/openssl-util.cc: http://gerrit.cloudera.org:8080/#/c/20447/10/be/src/util/openssl-util.cc@245 PS10, Line 245: } > In the first initialization, we initialize only evpCipher and in the second Please add a comment about that. http://gerrit.cloudera.org:8080/#/c/20447/12/be/src/util/openssl-util.cc File be/src/util/openssl-util.cc: http://gerrit.cloudera.org:8080/#/c/20447/12/be/src/util/openssl-util.cc@343 PS12, Line 343: memcpy(out+len, gcm_tag_, AES_BLOCK_SIZE); nit: inconsistent spacing around '+' operator. Choose one (looks like we tend to have spaces around the operator). -- To view, visit http://gerrit.cloudera.org:8080/20447 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3902f2b1d95da4d06995cbd687e79c48e16190c9 Gerrit-Change-Number: 20447 Gerrit-PatchSet: 12 Gerrit-Owner: Pranav Lodha <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Comment-Date: Wed, 24 Jul 2024 22:48:18 +0000 Gerrit-HasComments: Yes
