Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21530 )
Change subject: IMPALA-13166: Speed up getFullyQualifiedSlotPath ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/21530/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21530/1//COMMIT_MSG@7 PS1, Line 7: getFullyQualifiedSlotPath Do you mean getFullyQualifiedRawPath? http://gerrit.cloudera.org:8080/#/c/21530/1/fe/src/main/java/org/apache/impala/analysis/Path.java File fe/src/main/java/org/apache/impala/analysis/Path.java: http://gerrit.cloudera.org:8080/#/c/21530/1/fe/src/main/java/org/apache/impala/analysis/Path.java@172 PS1, Line 172: List<String> How about making this ImmutableList<String>? Said here that it might be slightly more memory efficient: https://github.com/DimitrisAndreou/memory-measurer/blob/master/ElementCostInDataStructures.txt https://github.com/google/guava/wiki/ImmutableCollectionsExplained Please add comment as well. http://gerrit.cloudera.org:8080/#/c/21530/1/fe/src/main/java/org/apache/impala/analysis/Path.java@450 PS1, Line 450: + 2 Does this means fullyQualifiedRawPath_ will always contain at least 2 items? -- To view, visit http://gerrit.cloudera.org:8080/21530 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If02d3b20a980508deafd2109a10676ab01e50981 Gerrit-Change-Number: 21530 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 24 Jul 2024 18:49:09 +0000 Gerrit-HasComments: Yes
