Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21599 )
Change subject: IMPALA-13243: Update Dropwizard Metrics to 4.2.x ...................................................................... Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/21599/1/java/pom.xml File java/pom.xml: http://gerrit.cloudera.org:8080/#/c/21599/1/java/pom.xml@398 PS1, Line 398: <dependency> : <groupId>io.dropwizard.metrics</groupId> : <artifactId>metrics-jvm</artifactId> : <version>${dropwizard-metrics.version}</version> : </dependency> : <dependency> : <groupId>io.dropwizard.metrics</groupId> : <artifactId>metrics-json</artifactId> : <version>${dropwizard-metrics.version}</version> : </dependency> Can we add a comment that this is only needed by HMS? In the future when Impala can run without HMS, we might need to remove/exclude this. -- To view, visit http://gerrit.cloudera.org:8080/21599 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie9bec7a7c23194604430531bd83b25c5969e888e Gerrit-Change-Number: 21599 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Mon, 22 Jul 2024 07:38:14 +0000 Gerrit-HasComments: Yes
