[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/21045 )
Change subject: IMPALA-12771: Impala catalogd events-skipped may mark the wrong number ...................................................................... Patch Set 13: (1 comment) http://gerrit.cloudera.org:8080/#/c/21045/11/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java File fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java: http://gerrit.cloudera.org:8080/#/c/21045/11/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@1995 PS11, Line 1995: response.getEvents_skipped() >= numEventsSkippedBefore + 2); we can see function https://github.com/apache/impala/blob/master/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java#L1453 for table create process. if event processor process event 2/3/4/5 and all skipped , as you said tables are all not loaded, we will get 4, but if 2 and 4 skipped we will get skipped metric of 2 . and I am not clear when will we get 3 ,also I not sure when CreateDatabase will be skipped. -- To view, visit http://gerrit.cloudera.org:8080/21045 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7aeb04e999b82187eb138c0b643ead259da22f1a Gerrit-Change-Number: 21045 Gerrit-PatchSet: 13 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Mon, 15 Jul 2024 14:28:32 +0000 Gerrit-HasComments: Yes
