Quanlong Huang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21039 )

Change subject: IMPALA-12786: Optimize count(*) for JSON scans
......................................................................


Patch Set 13: Code-Review+2

(1 comment)

Sorry to be late here. Carry Riza's +1. Thanks for improving this!

http://gerrit.cloudera.org:8080/#/c/21039/10/be/src/exec/json/json-parser-test.cc
File be/src/exec/json/json-parser-test.cc:

http://gerrit.cloudera.org:8080/#/c/21039/10/be/src/exec/json/json-parser-test.cc@247
PS10, Line 247:   constexpr int max_rows = 1024;
> Did you referring to checking whether the row count results obtained from S
Ack



--
To view, visit http://gerrit.cloudera.org:8080/21039
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I97ff097661c3c577aeafeeb1518408ce7a8a255e
Gerrit-Change-Number: 21039
Gerrit-PatchSet: 13
Gerrit-Owner: Zihao Ye <[email protected]>
Gerrit-Reviewer: Daniel Becker <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Reviewer: Zihao Ye <[email protected]>
Gerrit-Comment-Date: Wed, 10 Jul 2024 09:35:16 +0000
Gerrit-HasComments: Yes

Reply via email to