Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21557 )
Change subject: IMPALA-13088, IMPALA-13109: Use RoaringBitmap instead of sorted vector of int64s ...................................................................... Patch Set 9: (3 comments) Thanks for the comments! http://gerrit.cloudera.org:8080/#/c/21557/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21557/8//COMMIT_MSG@22 PS8, Line 22: lots of records > It could be interesting how the deleted rows were selected, as roaring bitm Added a section at the end. http://gerrit.cloudera.org:8080/#/c/21557/8//COMMIT_MSG@41 PS8, Line 41: : 10 executors cluster with sorted vector > Can you add a bit more info on this? What should be clarified is whether th You are right, we underestimated memory in case of MT_DOP > 1. It is also fixed now, and added planner tests. http://gerrit.cloudera.org:8080/#/c/21557/8//COMMIT_MSG@44 PS8, Line 44: > The memory estimations are not changed - this is intentional, as we assume No, it was an overlook. Good catch, btw! With RoaringBitmaps, 8 bytes per position is too much I think, so I adjusted the memory estimations to 1.5 bytes per position, which is probably still safe (2 bytes per position is worst-case scenario, and when it switches from ordered integers to bitmaps it uses 1 bit per position, and it can be even less with RLE). -- To view, visit http://gerrit.cloudera.org:8080/21557 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib769965d094149e99c43e0044914d9ecccc76107 Gerrit-Change-Number: 21557 Gerrit-PatchSet: 9 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 09 Jul 2024 17:31:59 +0000 Gerrit-HasComments: Yes
