Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21566 )
Change subject: IMPALA-13193: RuntimeFilter on parquet dictionary should evaluate NULL values ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/21566/3/be/src/exec/parquet/hdfs-parquet-scanner.cc File be/src/exec/parquet/hdfs-parquet-scanner.cc: http://gerrit.cloudera.org:8080/#/c/21566/3/be/src/exec/parquet/hdfs-parquet-scanner.cc@1927 PS3, Line 1927: if (!column_has_match) { > If null_count is set, then we should assume that it is reliable - if not, t I was uncertain on it. We should check __isset.null_count before using it though, and if not set then we need to always perform null value eval. -- To view, visit http://gerrit.cloudera.org:8080/21566 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0f69405c0c08feb47141d080a828847e5094163f Gerrit-Change-Number: 21566 Gerrit-PatchSet: 4 Gerrit-Owner: ttttttz <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Zihao Ye <[email protected]> Gerrit-Reviewer: ttttttz <[email protected]> Gerrit-Comment-Date: Tue, 09 Jul 2024 17:14:28 +0000 Gerrit-HasComments: Yes
