Zoltan Borok-Nagy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21562 )
Change subject: IMPALA-13190: Allow passing const _Atomic(T)* to LOAD operations ...................................................................... IMPALA-13190: Allow passing const _Atomic(T)* to LOAD operations There was an overlook in the C11 standard that didn't allow const argument for atomic_load operations. It was later revised, see https://www.open-std.org/jtc1/sc22/wg14/www/docs/n1807.htm Since then GCC/Clang allow passing const _Atomic(T)* in all versions of C. LLVM discussion thread: https://lists.llvm.org/pipermail/cfe-dev/2018-May/058129.html Clang fix: https://github.com/llvm/llvm-project/commit/b4b1f59869b1045258787f5a138f9710859cfe95 Change-Id: I2e257a41963dca777e1153b7153f56765a06075f Reviewed-on: http://gerrit.cloudera.org:8080/21562 Reviewed-by: Joe McDonnell <[email protected]> Tested-by: Zoltan Borok-Nagy <[email protected]> --- M buildall.sh A source/llvm/llvm-5.0.1-patches/0008-PATCH-__c11_atomic_load-s-_Atomic-can-be-const.patch 2 files changed, 71 insertions(+), 2 deletions(-) Approvals: Joe McDonnell: Looks good to me, approved Zoltan Borok-Nagy: Verified -- To view, visit http://gerrit.cloudera.org:8080/21562 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I2e257a41963dca777e1153b7153f56765a06075f Gerrit-Change-Number: 21562 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
