Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21238 )
Change subject: IMPALA-12964: Implement basic aggregation in the Calcite planner ...................................................................... Patch Set 11: (8 comments) http://gerrit.cloudera.org:8080/#/c/21238/11/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaAggRel.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaAggRel.java: http://gerrit.cloudera.org:8080/#/c/21238/11/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaAggRel.java@141 PS11, Line 141: List<Expr> outputExprs = createMappedOutputExprs(multiAggInfo, groupingExprs, aggExprs, line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/21238/11/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaAggRel.java@159 PS11, Line 159: private NodeWithExprs getChildPlanNode(ParentPlanRelContext context) throws ImpalaException { line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/21238/11/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaAggRel.java@184 PS11, Line 184: private List<List<Expr>> getGroupingSets(Analyzer analyzer, List<Expr> inputExprs) throws ImpalaException { line too long (109 > 90) http://gerrit.cloudera.org:8080/#/c/21238/11/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaAggRel.java@256 PS11, Line 256: secondPhaseAgg = new AggregationNode(ctx.getNextNodeId(), firstPhaseAgg, multiAggInfo, line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/21238/11/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaAggRel.java@329 PS11, Line 329: List<Expr> outputExprs = ImmutableList.of(inputNodeWithExprs.outputExprs_.get(inputRef)); line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/21238/11/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaAggRel.java@340 PS11, Line 340: public Aggregate copy(RelTraitSet relTraitSet, RelNode relNode, ImmutableBitSet groupSet, line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/21238/11/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaAggRel.java@354 PS11, Line 354: List<Expr> groupingExprs, List<FunctionCallExpr> aggExprs, List<SlotDescriptor> slotDescs) { line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/21238/11/java/calcite-planner/src/main/java/org/apache/impala/calcite/util/SimplifiedAnalyzer.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/util/SimplifiedAnalyzer.java: http://gerrit.cloudera.org:8080/#/c/21238/11/java/calcite-planner/src/main/java/org/apache/impala/calcite/util/SimplifiedAnalyzer.java@48 PS11, Line 48: * a basic analyzer that allows for analyzing/validating the final physical plan nodes, slots line too long (93 > 90) -- To view, visit http://gerrit.cloudera.org:8080/21238 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iacf0de8ba11f0d31d73d624f0c9a91db9997cfd5 Gerrit-Change-Number: 21238 Gerrit-PatchSet: 11 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Mon, 01 Jul 2024 20:25:09 +0000 Gerrit-HasComments: Yes
