Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21557 )
Change subject: IMPALA-13088: Use RoaringBitmap instead of sorted vector of int64s ...................................................................... Patch Set 2: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/21557/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21557/1//COMMIT_MSG@11 PS1, Line 11: CRoaring library (version 4.0.0). CRoaring also offers C++ classes, > Done Ack http://gerrit.cloudera.org:8080/#/c/21557/1/be/src/thirdparty/roaring/README.md File be/src/thirdparty/roaring/README.md: http://gerrit.cloudera.org:8080/#/c/21557/1/be/src/thirdparty/roaring/README.md@29 PS1, Line 29: So one just needs to download the amalgamated files and override the > Done Ack http://gerrit.cloudera.org:8080/#/c/21557/2/be/src/util/roaring-bitmap-test.cc File be/src/util/roaring-bitmap-test.cc: http://gerrit.cloudera.org:8080/#/c/21557/2/be/src/util/roaring-bitmap-test.cc@33 PS2, Line 33: ASSERT_FALSE(rbm.ContainsBulk(1, &context)); nit: might as well check the upper bound (with e.g. 30). -- To view, visit http://gerrit.cloudera.org:8080/21557 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib769965d094149e99c43e0044914d9ecccc76107 Gerrit-Change-Number: 21557 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 28 Jun 2024 21:43:12 +0000 Gerrit-HasComments: Yes
