Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21546 )
Change subject: IMPALA-9441,IMPALA-13170: Ops listing dbs/tables should handle db not exists ...................................................................... Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/21546/1/common/thrift/CatalogService.thrift File common/thrift/CatalogService.thrift: http://gerrit.cloudera.org:8080/#/c/21546/1/common/thrift/CatalogService.thrift@615 PS1, Line 615: VERSION_MISMATCH > nit: maybe VERSION_MISMATCH would be better from a grammar perspective Done http://gerrit.cloudera.org:8080/#/c/21546/1/tests/authorization/test_authorization.py File tests/authorization/test_authorization.py: http://gerrit.cloudera.org:8080/#/c/21546/1/tests/authorization/test_authorization.py@248 PS1, Line 248: > flake8: E306 expected 1 blank line before a nested definition, found 0 Done http://gerrit.cloudera.org:8080/#/c/21546/1/tests/authorization/test_authorization.py@265 PS1, Line 265: finally: > shouldn't be thread joined first? I assume that drop database could throw a Good point! Done. http://gerrit.cloudera.org:8080/#/c/21546/1/tests/hs2/test_hs2.py File tests/hs2/test_hs2.py: http://gerrit.cloudera.org:8080/#/c/21546/1/tests/hs2/test_hs2.py@477 PS1, Line 477: > flake8: E306 expected 1 blank line before a nested definition, found 0 Done http://gerrit.cloudera.org:8080/#/c/21546/1/tests/hs2/test_hs2.py@501 PS1, Line 501: u > flake8: E306 expected 1 blank line before a nested definition, found 0 Done -- To view, visit http://gerrit.cloudera.org:8080/21546 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2bd40d33859feca2bbd2e5f1158f3894a91c2929 Gerrit-Change-Number: 21546 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 27 Jun 2024 03:58:25 +0000 Gerrit-HasComments: Yes
