Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21542 )
Change subject: IMPALA-13028: Strip dynamic link libraries in Linux DEB/RPM packages ...................................................................... Patch Set 4: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/21542/4/package/strip.cmake File package/strip.cmake: http://gerrit.cloudera.org:8080/#/c/21542/4/package/strip.cmake@19 PS4, Line 19: *[!y] Could you add a comment for this expression? Is this for ignoring the accidentally added python files like libstdc++.so.6.0.28-gdb.py? -- To view, visit http://gerrit.cloudera.org:8080/21542 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie7bee0b4ef904db3706a350f17bcd68d769aa5ad Gerrit-Change-Number: 21542 Gerrit-PatchSet: 4 Gerrit-Owner: Xiang Yang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Xiang Yang <[email protected]> Gerrit-Comment-Date: Tue, 25 Jun 2024 09:06:16 +0000 Gerrit-HasComments: Yes
