Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21544 )
Change subject: IMPALA-13128: disk-file-test Hangs on ARM + UBSAN Test Jobs ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/21544/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21544/2//COMMIT_MSG@13 PS2, Line 13: See https://github.com/google/googletest/blob/main/docs/advanced.md#death-tests What does this do to backend test execution time? http://gerrit.cloudera.org:8080/#/c/21544/2/CMakeLists.txt File CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/21544/2/CMakeLists.txt@123 PS2, Line 123: set(GTEST_ROOT Huh, apparently we haven't used the newer versions of gtest mentioned in https://gerrit.cloudera.org/c/21133/5/buildall.sh#143 until now. Could you simplify all this by changing the names to GOOGLETEST? i.e. IMPALA_GOOGLETEST_VERSION, GOOGLETEST_ROOT, etc? http://gerrit.cloudera.org:8080/#/c/21544/2/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: http://gerrit.cloudera.org:8080/#/c/21544/2/be/src/exprs/expr-test.cc@11430 PS2, Line 11430: INSTANTIATE_TEST_SUITE_P(Instantiations, ExprTest, ::testing::Values( This was renamed in newer googletest versions? -- To view, visit http://gerrit.cloudera.org:8080/21544 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie01f7781f24644a66e9ec52652450116f5cb4297 Gerrit-Change-Number: 21544 Gerrit-PatchSet: 2 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Fri, 21 Jun 2024 21:18:46 +0000 Gerrit-HasComments: Yes
