Jankiram Balakrishnan has posted comments on this change. ( http://gerrit.cloudera.org:8080/21539 )
Change subject: IMPALA-12754: [DOCS] External JDBC table support ...................................................................... Patch Set 2: (14 comments) Thanks for your feedback, Wenzhe. I have incorporated your comments and published another patch. http://gerrit.cloudera.org:8080/#/c/21539/1/docs/topics/impala_jdbc_external_table.xml File docs/topics/impala_jdbc_external_table.xml: http://gerrit.cloudera.org:8080/#/c/21539/1/docs/topics/impala_jdbc_external_table.xml@22 PS1, Line 22: Using Impala to Query External JDBC Data Sour > Change title as "Using Impala to Query External JDBC Data Sources" Done http://gerrit.cloudera.org:8080/#/c/21539/1/docs/topics/impala_jdbc_external_table.xml@40 PS1, Line 40: external JDBC > external JDBC table Done http://gerrit.cloudera.org:8080/#/c/21539/1/docs/topics/impala_jdbc_external_table.xml@41 PS1, Line 41: EXTERNAL T > key word 'EXTERNAL' is mandatory for creating JDBC table, remove square bra Done http://gerrit.cloudera.org:8080/#/c/21539/1/docs/topics/impala_jdbc_external_table.xml@70 PS1, Line 70: 2/<i > change to default Postgres port: 5432 Done http://gerrit.cloudera.org:8080/#/c/21539/1/docs/topics/impala_jdbc_external_table.xml@93 PS1, Line 93: 50/< > change to Impala default HS2 port: 21050 Done http://gerrit.cloudera.org:8080/#/c/21539/1/docs/topics/impala_jdbc_external_table.xml@98 PS1, Line 98: > add a line break Done http://gerrit.cloudera.org:8080/#/c/21539/1/docs/topics/impala_jdbc_external_table.xml@107 PS1, Line 107: > or IMPALA Done http://gerrit.cloudera.org:8080/#/c/21539/1/docs/topics/impala_jdbc_external_table.xml@109 PS1, Line 109: codeph>: > hostname/IP address Done http://gerrit.cloudera.org:8080/#/c/21539/1/docs/topics/impala_jdbc_external_table.xml@129 PS1, Line 129: f the Ja > change to URI Done http://gerrit.cloudera.org:8080/#/c/21539/1/docs/topics/impala_jdbc_external_table.xml@142 PS1, Line 142: > an Impala external Done http://gerrit.cloudera.org:8080/#/c/21539/1/docs/topics/impala_jdbc_external_table.xml@154 PS1, Line 154: > Impala external Done http://gerrit.cloudera.org:8080/#/c/21539/1/docs/topics/impala_jdbc_external_table.xml@156 PS1, Line 156: _5bc"> : <li dir="ltr">Following column types are not support > Following column data types are not supported: Done http://gerrit.cloudera.org:8080/#/c/21539/1/docs/topics/impala_jdbc_external_table.xml@194 PS1, Line 194: > replace it with one space Done http://gerrit.cloudera.org:8080/#/c/21539/1/docs/topics/impala_jdbc_external_table.xml@211 PS1, Line 211: eading extern > external JDBC Done -- To view, visit http://gerrit.cloudera.org:8080/21539 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5360389037ae9ee675ab406d87617d55d476bf8f Gerrit-Change-Number: 21539 Gerrit-PatchSet: 2 Gerrit-Owner: Jankiram Balakrishnan <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jankiram Balakrishnan <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: gaurav singh <[email protected]> Gerrit-Comment-Date: Thu, 20 Jun 2024 03:47:21 +0000 Gerrit-HasComments: Yes
