Peter Rozsa has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21492 )

Change subject: IMPALA-12370: Allow converting timestamps to UTC when writing 
to Kudu
......................................................................


Patch Set 8: Code-Review+1

(3 comments)

http://gerrit.cloudera.org:8080/#/c/21492/8//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/21492/8//COMMIT_MSG@13
PS8, Line 13: ambigious
nit: ambiguous


http://gerrit.cloudera.org:8080/#/c/21492/8//COMMIT_MSG@16
PS8, Line 16: affected
nit: duplicated word


http://gerrit.cloudera.org:8080/#/c/21492/8/testdata/workloads/functional-planner/queries/PlannerTest/kudu-dml-with-utc-conversion.test
File 
testdata/workloads/functional-planner/queries/PlannerTest/kudu-dml-with-utc-conversion.test:

http://gerrit.cloudera.org:8080/#/c/21492/8/testdata/workloads/functional-planner/queries/PlannerTest/kudu-dml-with-utc-conversion.test@116
PS8, Line 116:
nit: superfluous empty lines



--
To view, visit http://gerrit.cloudera.org:8080/21492
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb4995a64e042e7bb261fcc6e6bf7ffce61e9bd1
Gerrit-Change-Number: 21492
Gerrit-PatchSet: 8
Gerrit-Owner: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Ashwani Raina <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Peter Rozsa <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Reviewer: Zihao Ye <[email protected]>
Gerrit-Comment-Date: Tue, 18 Jun 2024 08:52:03 +0000
Gerrit-HasComments: Yes

Reply via email to