Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21504 )
Change subject: IMPALA-13152: Avoid NaN, infinite, and negative ProcessingCost ...................................................................... Patch Set 3: (3 comments) > Should we distinguish between missing cardinality information and 0 > cardinality? Agree, but I rather address it later in separate patch. The way it is now in this patch set 3, Planner will bias towards assigning to smaller executor group set if cardinality is unknown (ProcessingCost is likely to be 0 for PlanNode with unknown cardinality). http://gerrit.cloudera.org:8080/#/c/21504/3/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java: http://gerrit.cloudera.org:8080/#/c/21504/3/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@a2231 PS3, Line 2231: > Why is this check no longer required? This is removed to allow ProcessingCost computation if COMPUTE_PROCESSING_COST=False, but TEST_REPLAN=True or RuntimeEnv.INSTANCE.isTestEnv() is True. http://gerrit.cloudera.org:8080/#/c/21504/3/fe/src/main/java/org/apache/impala/planner/ScanNode.java File fe/src/main/java/org/apache/impala/planner/ScanNode.java: http://gerrit.cloudera.org:8080/#/c/21504/3/fe/src/main/java/org/apache/impala/planner/ScanNode.java@a399 PS3, Line 399: > Why this check is no longer required? This is removed to allow ProcessingCost computation if COMPUTE_PROCESSING_COST=False, but TEST_REPLAN=True or RuntimeEnv.INSTANCE.isTestEnv() is True. http://gerrit.cloudera.org:8080/#/c/21504/3/fe/src/main/java/org/apache/impala/planner/ScanNode.java@a420 PS3, Line 420: > Same question. This is removed to allow ProcessingCost computation if COMPUTE_PROCESSING_COST=False, but TEST_REPLAN=True or RuntimeEnv.INSTANCE.isTestEnv() is True. -- To view, visit http://gerrit.cloudera.org:8080/21504 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib49c7ae397dadcb2cb69fde1850d442d33cdf177 Gerrit-Change-Number: 21504 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: David Rorke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Fri, 14 Jun 2024 22:49:49 +0000 Gerrit-HasComments: Yes
