Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21482 )
Change subject: IMPALA-13137: Add additional client fetch metrics columns to the queries page ...................................................................... Patch Set 4: (6 comments) http://gerrit.cloudera.org:8080/#/c/21482/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21482/4//COMMIT_MSG@11 PS4, Line 11: - First row fetched time : - Client fetch wait time Match this with chosen label in queries.tmpl http://gerrit.cloudera.org:8080/#/c/21482/4//COMMIT_MSG@18 PS4, Line 18: fetch all rows "fetch all rows since the first row" http://gerrit.cloudera.org:8080/#/c/21482/4/be/src/service/impala-http-handler.cc File be/src/service/impala-http-handler.cc: http://gerrit.cloudera.org:8080/#/c/21482/4/be/src/service/impala-http-handler.cc@463 PS4, Line 463: " fetch all rows." " fetch all rows since the first row." http://gerrit.cloudera.org:8080/#/c/21482/4/be/src/service/impala-http-handler.cc@548 PS4, Line 548: "First row fetched" Make this a constant and share it with the same occurrence in coordinator.cc runtime/coordinator.cc:1051: query_events_->MarkEvent("First row fetched"); http://gerrit.cloudera.org:8080/#/c/21482/3/www/queries.tmpl File www/queries.tmpl: http://gerrit.cloudera.org:8080/#/c/21482/3/www/queries.tmpl@84 PS3, Line 84: <td>{{default_db}}</td> : <td><samp>{{stmt_type}}</samp></td> > I agree. Done. Done http://gerrit.cloudera.org:8080/#/c/21482/4/www/queries.tmpl File www/queries.tmpl: http://gerrit.cloudera.org:8080/#/c/21482/4/www/queries.tmpl@117 PS4, Line 117: <span title="{{tips_first_row_fetched}}">First row fetched</span> : <hr style="margin-top:0px;margin-bottom:0px;"/> : <span title="{{tips_client_fetch_wait_time}}">Client fetch wait time</span> nit: Since this column is all about Client time, I'd suggest shorter label "First Fetch" and "Fetch Duration". Does that make sense? -- To view, visit http://gerrit.cloudera.org:8080/21482 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I74a9393a7b38750de0c3f6230b6e5e048048c4b5 Gerrit-Change-Number: 21482 Gerrit-PatchSet: 4 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Thu, 13 Jun 2024 20:59:47 +0000 Gerrit-HasComments: Yes
