Michael Smith has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21502 )

Change subject: IMPALA-13138: Never smallify existing StringValue objects, only 
new ones during DeepCopy
......................................................................


Patch Set 3: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/21502/2/tests/query_test/test_join_queries.py
File tests/query_test/test_join_queries.py:

http://gerrit.cloudera.org:8080/#/c/21502/2/tests/query_test/test_join_queries.py@219
PS2, Line 219:
> Thanks for reminding me this. Done.
Ack



--
To view, visit http://gerrit.cloudera.org:8080/21502
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I739048b37a59a81c41c85d475fad00cb520a5f99
Gerrit-Change-Number: 21502
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Gabor Kaszab <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Wed, 12 Jun 2024 21:48:37 +0000
Gerrit-HasComments: Yes

Reply via email to