Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21484 )
Change subject: IMPALA-12800: Add null slots cache ...................................................................... Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/21484/8/common/thrift/ImpalaService.thrift File common/thrift/ImpalaService.thrift: http://gerrit.cloudera.org:8080/#/c/21484/8/common/thrift/ImpalaService.thrift@947 PS8, Line 947: USE_NULL_SLOTS_CACHE = 179 > What do you think of using custom Guava Weigher that weight each entry as 1 If they all have the same weight, might as well use maxSize. We could make this an option to configure maxSize. It's a short-lived cache that scales based on number of expressions, so I don't expect the overall cost to be that high. I lean towards keeping the configuration simpler, but open to changing it to a query option that sets the cache max size. -- To view, visit http://gerrit.cloudera.org:8080/21484 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib63f5553284f21f775d2097b6c5d6bbb63699acd Gerrit-Change-Number: 21484 Gerrit-PatchSet: 8 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Mon, 10 Jun 2024 18:05:15 +0000 Gerrit-HasComments: Yes
