Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/21482 )
Change subject: IMPALA-13137: Add additional client fetch metrics columns to the queries page ...................................................................... Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/21482/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21482/1//COMMIT_MSG@9 PS1, Line 9: . nit: , http://gerrit.cloudera.org:8080/#/c/21482/1//COMMIT_MSG@10 PS1, Line 10: The nit: the http://gerrit.cloudera.org:8080/#/c/21482/1/be/src/service/impala-http-handler.cc File be/src/service/impala-http-handler.cc: http://gerrit.cloudera.org:8080/#/c/21482/1/be/src/service/impala-http-handler.cc@460 PS1, Line 460: , nit: move ',' to previous line http://gerrit.cloudera.org:8080/#/c/21482/1/be/src/service/impala-http-handler.cc@551 PS1, Line 551: first_row_fetched_ns = 0; nit: it's already inited as 0, not necessary to set http://gerrit.cloudera.org:8080/#/c/21482/1/be/src/service/impala-http-handler.cc@567 PS1, Line 567: , nit: move '' to previous line -- To view, visit http://gerrit.cloudera.org:8080/21482 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I74a9393a7b38750de0c3f6230b6e5e048048c4b5 Gerrit-Change-Number: 21482 Gerrit-PatchSet: 1 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Fri, 07 Jun 2024 18:58:23 +0000 Gerrit-HasComments: Yes
