ttttttz has posted comments on this change. ( http://gerrit.cloudera.org:8080/21418 )
Change subject: IMPALA-12705: Add /catalog_ha_info page on Statestore to show catalog HA information ...................................................................... Patch Set 14: (7 comments) http://gerrit.cloudera.org:8080/#/c/21418/12/be/src/statestore/statestore.h File be/src/statestore/statestore.h: http://gerrit.cloudera.org:8080/#/c/21418/12/be/src/statestore/statestore.h@514 PS12, Line 514: TStatestoreSubscriberType::type subscriber_type() const { return subscriber_type_; } : int64_t catalogd_version() const { return catalogd_version_; } : c > nit: It can be written in one line to be consistent with the context. Ack http://gerrit.cloudera.org:8080/#/c/21418/12/be/src/statestore/statestore.h@585 PS12, Line 585: te: > nit: Unnecessary const Ack http://gerrit.cloudera.org:8080/#/c/21418/12/common/thrift/StatestoreService.thrift File common/thrift/StatestoreService.thrift: http://gerrit.cloudera.org:8080/#/c/21418/12/common/thrift/StatestoreService.thrift@222 PS12, Line 222: registration_time > nit: Missing a semicolon. Ack http://gerrit.cloudera.org:8080/#/c/21418/13/tests/webserver/test_web_pages.py File tests/webserver/test_web_pages.py: http://gerrit.cloudera.org:8080/#/c/21418/13/tests/webserver/test_web_pages.py@1175 PS13, Line 1175: enab > nit: ha_flags Ack http://gerrit.cloudera.org:8080/#/c/21418/13/tests/webserver/test_web_pages.py@1184 PS13, Line 1184: h > flake8: E712 comparison to True should be 'if cond is True:' or 'if cond:' Ack http://gerrit.cloudera.org:8080/#/c/21418/13/tests/webserver/test_web_pages.py@1187 PS13, Line 1187: > flake8: E501 line too long (108 > 90 characters) Ack http://gerrit.cloudera.org:8080/#/c/21418/13/tests/webserver/test_web_pages.py@1191 PS13, Line 1191: met > Is this condition triggered during test? Ack -- To view, visit http://gerrit.cloudera.org:8080/21418 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If85f6a827ae8180d13caac588b92af0511ac35e3 Gerrit-Change-Number: 21418 Gerrit-PatchSet: 14 Gerrit-Owner: ttttttz <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Zihao Ye <[email protected]> Gerrit-Reviewer: ttttttz <[email protected]> Gerrit-Comment-Date: Fri, 31 May 2024 02:32:56 +0000 Gerrit-HasComments: Yes
