Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21458 )
Change subject: IMPALA-13107: Don't start query on executor if instance number equals 0 ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/21458/2/be/src/runtime/coordinator-backend-state.cc File be/src/runtime/coordinator-backend-state.cc: http://gerrit.cloudera.org:8080/#/c/21458/2/be/src/runtime/coordinator-backend-state.cc@185 PS2, Line 185: DCHECK_GT(fragment_info->fragments.size(), 0); Maybe add this as well? DCHECK_EQ(fragment_info->fragments.size(), request->fragment_ctxs_size()); DCHECK_EQ(fragment_info->fragment_instance_ctxs.size(), request->fragment_instance_ctxs_size()); http://gerrit.cloudera.org:8080/#/c/21458/1/be/src/service/control-service.cc File be/src/service/control-service.cc: http://gerrit.cloudera.org:8080/#/c/21458/1/be/src/service/control-service.cc@154 PS1, Line 154: fragment_info.fragments.size() == 0 : || fragment_info.fragment_instance_ctxs.size() == 0 > Added DCHECK in Coordinator::BackendState::SetRpcParams as suggested. Done -- To view, visit http://gerrit.cloudera.org:8080/21458 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie92ee120f1e9369f8dc2512792a05b7f8be5f007 Gerrit-Change-Number: 21458 Gerrit-PatchSet: 2 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Tue, 28 May 2024 21:37:24 +0000 Gerrit-HasComments: Yes
