Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20221 )
Change subject: IMPALA-11871: Skip permissions loading and check on HDFS if Ranger is enabled ...................................................................... Patch Set 11: (4 comments) http://gerrit.cloudera.org:8080/#/c/20221/11/tests/authorization/test_ranger.py File tests/authorization/test_ranger.py: http://gerrit.cloudera.org:8080/#/c/20221/11/tests/authorization/test_ranger.py@89 PS11, Line 89: Impala's FsPermissionChecker nit: "HDFS permissions" might be more clear. http://gerrit.cloudera.org:8080/#/c/20221/11/tests/authorization/test_ranger.py@168 PS11, Line 168: we will encounter an AnalysisException : # thrown from partitionSpec_.analyze() in LoadDataStmt#analyze() due to Details of the codes might be stale in the future. We can just comment that LOAD DATA can't create new partitions. http://gerrit.cloudera.org:8080/#/c/20221/11/tests/authorization/test_ranger.py@173 PS11, Line 173: user=ADMIN) Could you add a test here showing the same LOAD DATA statement fails? http://gerrit.cloudera.org:8080/#/c/20221/11/tests/authorization/test_ranger.py@197 PS11, Line 197: unique_table, partition_column, partition_value), user, True) Or could you add a test after revoking the privilege? It'd be better to have some negative tests (i.e. auth failures). -- To view, visit http://gerrit.cloudera.org:8080/20221 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id33c400fbe0c918b6b65d713b09009512835a4c9 Gerrit-Change-Number: 20221 Gerrit-PatchSet: 11 Gerrit-Owner: Halim Kim <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Halim Kim <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Tue, 28 May 2024 02:46:40 +0000 Gerrit-HasComments: Yes
