Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21200 )
Change subject: IMPALA-12939: Bound IMPALA_BUILD_THREADS for cgroups and memory ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/21200/5/bin/impala-config.sh File bin/impala-config.sh: http://gerrit.cloudera.org:8080/#/c/21200/5/bin/impala-config.sh@1042 PS5, Line 1042: AVAILABLE_MEM=$(awk '/MemTotal/{print int($2/1024/1024)}' /proc/meminfo) Just as CORES, can we set reasonable AVAILABLE_MEM by default if /proc/meminfo does not exist (ie., IS_OSX in L577 is true)? Maybe 8 or 16? I know Impala only build in Linux now, but just in case we can do ARM Mac in the future. -- To view, visit http://gerrit.cloudera.org:8080/21200 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I87994d0464073fe2d91bc2f7c2592c012e42de71 Gerrit-Change-Number: 21200 Gerrit-PatchSet: 5 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 23 May 2024 16:41:24 +0000 Gerrit-HasComments: Yes
