Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21383 )
Change subject: IMPALA-13040: Add waiting mechanism in UpdateFilterFromRemote ...................................................................... Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/21383/9/be/src/util/network-util.cc File be/src/util/network-util.cc: http://gerrit.cloudera.org:8080/#/c/21383/9/be/src/util/network-util.cc@243 PS9, Line 243: if (address.has_uds_address()) t_address.__set_uds_address(address.uds_address()); Found one issue after this change: https://github.com/apache/impala/blob/d1d28c0/be/src/service/query-state-record.cc#L224-L227 For consistency, these lines of code should be replaced with: TNetworkAddress host = FromNetworkAddressPB(b.address()); -- To view, visit http://gerrit.cloudera.org:8080/21383 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I156d1f0c694b91ba34be70bc53ae9bacf924b3b9 Gerrit-Change-Number: 21383 Gerrit-PatchSet: 9 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 09 May 2024 20:14:34 +0000 Gerrit-HasComments: Yes
