Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21131 )
Change subject: IMPALA-11499: Refactor UrlEncode function to handle special characters ...................................................................... Patch Set 19: (7 comments) http://gerrit.cloudera.org:8080/#/c/21131/19/be/src/util/coding-util-test.cc File be/src/util/coding-util-test.cc: http://gerrit.cloudera.org:8080/#/c/21131/19/be/src/util/coding-util-test.cc@96 PS19, Line 96: string test = "SpecialCharacters\x01\x02\x03\x04\x05\x06\x07\b\t\n\v\f\r\x0E\x0F\x10\x11" line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/21131/19/tests/query_test/test_insert.py File tests/query_test/test_insert.py: http://gerrit.cloudera.org:8080/#/c/21131/19/tests/query_test/test_insert.py@300 PS19, Line 300: e flake8: E501 line too long (106 > 90 characters) http://gerrit.cloudera.org:8080/#/c/21131/19/tests/query_test/test_insert.py@301 PS19, Line 301: E flake8: E501 line too long (104 > 90 characters) http://gerrit.cloudera.org:8080/#/c/21131/19/tests/query_test/test_insert.py@302 PS19, Line 302: " flake8: E501 line too long (107 > 90 characters) http://gerrit.cloudera.org:8080/#/c/21131/19/tests/query_test/test_insert.py@302 PS19, Line 302: # flake8: E261 at least two spaces before inline comment http://gerrit.cloudera.org:8080/#/c/21131/19/tests/query_test/test_insert.py@302 PS19, Line 302: # flake8: E262 inline comment should start with '# ' http://gerrit.cloudera.org:8080/#/c/21131/19/tests/query_test/test_insert.py@303 PS19, Line 303: _ flake8: E501 line too long (104 > 90 characters) -- To view, visit http://gerrit.cloudera.org:8080/21131 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I88c4aba5d811dfcec809583d0c16fcbc0ca730fb Gerrit-Change-Number: 21131 Gerrit-PatchSet: 19 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zihao Ye <[email protected]> Gerrit-Comment-Date: Mon, 06 May 2024 21:19:38 +0000 Gerrit-HasComments: Yes
