Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21367 )
Change subject: IMPALA-13020: Change thrift_rpc_max_message_size to int64_t ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/21367/4/be/src/rpc/thrift-util.cc File be/src/rpc/thrift-util.cc: http://gerrit.cloudera.org:8080/#/c/21367/4/be/src/rpc/thrift-util.cc@61 PS4, Line 61: DEFINE_int64(thrift_rpc_max_message_size, 4L * 1024 * 1024 * 1024, > Can we set it to unlimited or a larger value? We have customers using impal Is 8GB reasonable? Setting it to unlimited means there is no protection from the CVE that prompted it. That is probably ok for messages that we send within the Impala cluster, but we use the same limit for external clients. -- To view, visit http://gerrit.cloudera.org:8080/21367 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I681b1849cc565dcb25de8c070c18776ce69cbb87 Gerrit-Change-Number: 21367 Gerrit-PatchSet: 4 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Mon, 06 May 2024 18:03:58 +0000 Gerrit-HasComments: Yes
