Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21194 )
Change subject: IMPALA-12934: Added Calcite parsing files to Impala ...................................................................... Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/21194/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21194/8//COMMIT_MSG@18 PS8, Line 18: The config.fmpp file was grabbed from Calcite 1.36 default_config.fmpp. It does : have two very small modifications from the original Calcite fmpp file in order : to fix compilation issues within Impala : : 1) the entire json is wrapped with a "data {}" tag : 2) the class used is ImpalaSqlParserImpl as opposed to the Calcite SqlParserImpl : class to prevent naming collisions with Calcite. > Let me check my understanding: Ok, modified the message a bit. I hope I hit the points you mentioned. If not, I can modify again. -- To view, visit http://gerrit.cloudera.org:8080/21194 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If756b5ea8beb85661a30fb5d029e74ebb6719767 Gerrit-Change-Number: 21194 Gerrit-PatchSet: 8 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Mon, 06 May 2024 16:49:30 +0000 Gerrit-HasComments: Yes
