Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21367 )
Change subject: PROTOTYPE: IMPALA-13020: Change thrift_rpc_max_message_size to int64_t ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/21367/2/fe/src/main/java/org/apache/impala/service/BackendConfig.java File fe/src/main/java/org/apache/impala/service/BackendConfig.java: http://gerrit.cloudera.org:8080/#/c/21367/2/fe/src/main/java/org/apache/impala/service/BackendConfig.java@411 PS2, Line 411: return (int) Math.min(backendCfg_.thrift_rpc_max_message_size, Integer.MAX_VALUE); > What's the rationale for not increasing it? No major reason. Mainly, I'm doing C++ because C++ is easy for us to patch and the specific bug for IMPALA-13020 involves C++ to C++ communication. We should think about modifying the Java library to support a higher limit. We haven't established a way to patch the Java library yet. We also have to think about how Hive uses Thrift and whether it would need to be recompiled if we change the Thrift signature. -- To view, visit http://gerrit.cloudera.org:8080/21367 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I681b1849cc565dcb25de8c070c18776ce69cbb87 Gerrit-Change-Number: 21367 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Mon, 29 Apr 2024 17:16:11 +0000 Gerrit-HasComments: Yes
