Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21302 )
Change subject: IMPALA-13005: Create Query Live table in HMS ...................................................................... Patch Set 14: (2 comments) http://gerrit.cloudera.org:8080/#/c/21302/14/tests/custom_cluster/test_query_live.py File tests/custom_cluster/test_query_live.py: http://gerrit.cloudera.org:8080/#/c/21302/14/tests/custom_cluster/test_query_live.py@132 PS14, Line 132: insert_result > nit: create_result? Ack http://gerrit.cloudera.org:8080/#/c/21302/14/tests/custom_cluster/test_query_live.py@137 PS14, Line 137: insert_result = self.execute_query_expect_failure(self.client, : 'insert into sys.impala_query_live select * from sys.impala_query_live limit 1') > nit: missing "drop table" test? Because it's in HMS, drop table actually succeeds. It gets recreated the next time Impala starts up. I could put one at the end of this case demonstrating that. -- To view, visit http://gerrit.cloudera.org:8080/21302 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idf302ee54a819fdee2db0ae582a5eeddffe4a5b4 Gerrit-Change-Number: 21302 Gerrit-PatchSet: 14 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Fri, 26 Apr 2024 17:18:23 +0000 Gerrit-HasComments: Yes
