Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20447 )
Change subject: IMPALA-13039: AES Encryption/ Decryption Support in Impala ...................................................................... Patch Set 9: (7 comments) http://gerrit.cloudera.org:8080/#/c/20447/9/be/src/util/openssl-util-test.cc File be/src/util/openssl-util-test.cc: http://gerrit.cloudera.org:8080/#/c/20447/9/be/src/util/openssl-util-test.cc@68 PS9, Line 68: AES_CIPHER_MODE modes[] = {impala::AES_CIPHER_MODE::AES_256_GCM, impala::AES_CIPHER_MODE::AES_256_CTR, impala::AES_CIPHER_MODE::AES_256_CFB}; line too long (145 > 90) http://gerrit.cloudera.org:8080/#/c/20447/9/be/src/util/openssl-util-test.cc@98 PS9, Line 98: AES_CIPHER_MODE modes[] = {impala::AES_CIPHER_MODE::AES_256_GCM, impala::AES_CIPHER_MODE::AES_256_CTR, impala::AES_CIPHER_MODE::AES_256_CFB}; line too long (143 > 90) http://gerrit.cloudera.org:8080/#/c/20447/9/be/src/util/openssl-util.h File be/src/util/openssl-util.h: http://gerrit.cloudera.org:8080/#/c/20447/9/be/src/util/openssl-util.h@154 PS9, Line 154: /// calling this function. If 'in' == 'out', the operation is performed in-place; otherwise, line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/20447/9/be/src/util/openssl-util.h@157 PS9, Line 157: Status Encrypt(const uint8_t* data, int64_t len, uint8_t* out, int64_t* data_read = NULL) WARN_UNUSED_RESULT; line too long (111 > 90) http://gerrit.cloudera.org:8080/#/c/20447/9/be/src/util/openssl-util.h@164 PS9, Line 164: Status Decrypt(const uint8_t* data, int64_t len, uint8_t* out, int64_t* data_read = NULL) WARN_UNUSED_RESULT; line too long (111 > 90) http://gerrit.cloudera.org:8080/#/c/20447/9/be/src/util/openssl-util.cc File be/src/util/openssl-util.cc: http://gerrit.cloudera.org:8080/#/c/20447/9/be/src/util/openssl-util.cc@201 PS9, Line 201: Status EncryptionKey::Encrypt(const uint8_t* data, int64_t len, uint8_t* out, int64_t* data_read) { line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/20447/9/be/src/util/openssl-util.cc@205 PS9, Line 205: Status EncryptionKey::Decrypt(const uint8_t* data, int64_t len, uint8_t* out, int64_t* data_read) { line too long (99 > 90) -- To view, visit http://gerrit.cloudera.org:8080/20447 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3902f2b1d95da4d06995cbd687e79c48e16190c9 Gerrit-Change-Number: 20447 Gerrit-PatchSet: 9 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Fri, 26 Apr 2024 16:16:55 +0000 Gerrit-HasComments: Yes
