[email protected] has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/21131 )
Change subject: IMPALA-11499: Refactor UrlEncode function to handle special characters ...................................................................... IMPALA-11499: Refactor UrlEncode function to handle special characters The previous code suffered from URL encoding errors due to incomplete character whitelisting and inadequate handling of Unicode characters. This commit addresses these issues by introducing a specialCharacterMap that accurately maps special characters to their URL-encoded forms. The UrlEncode function now utilizes this map to determine whether a character should be escaped. If present in the map, the character's encoded form is used; otherwise, it falls back to hexadecimal encoding. Additionally, the function clears the output string before encoding to ensure a clean start and efficiently accumulates encoded characters using stringstream. These improvements ensure accurate encoding of all characters, including special and Unicode characters, resolving the errors encountered during URL encoding. Testing: Some basic tests are provided in unicode-column-name.test. Change-Id: I88c4aba5d811dfcec809583d0c16fcbc0ca730fb --- M be/src/util/coding-util.cc M testdata/workloads/functional-query/queries/QueryTest/unicode-column-name.test 2 files changed, 77 insertions(+), 19 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/31/21131/6 -- To view, visit http://gerrit.cloudera.org:8080/21131 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I88c4aba5d811dfcec809583d0c16fcbc0ca730fb Gerrit-Change-Number: 21131 Gerrit-PatchSet: 6 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zihao Ye <[email protected]>
